[GitHub] [flink] HuangZhenQiu commented on pull request #14678: [FLINK-20833][runtime] Add pluggable failure listener in job manager

2022-05-09 Thread GitBox
HuangZhenQiu commented on PR #14678: URL: https://github.com/apache/flink/pull/14678#issuecomment-1121273392 @zentol Would you please help to review this RP? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] HuangZhenQiu commented on pull request #14678: [FLINK-20833][runtime] Add pluggable failure listener in job manager

2022-05-06 Thread GitBox
HuangZhenQiu commented on PR #14678: URL: https://github.com/apache/flink/pull/14678#issuecomment-1119584546 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] HuangZhenQiu commented on pull request #14678: [FLINK-20833][runtime] Add pluggable failure listener in job manager

2021-02-23 Thread GitBox
HuangZhenQiu commented on pull request #14678: URL: https://github.com/apache/flink/pull/14678#issuecomment-784358861 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] HuangZhenQiu commented on pull request #14678: [FLINK-20833][runtime] Add pluggable failure listener in job manager

2021-02-03 Thread GitBox
HuangZhenQiu commented on pull request #14678: URL: https://github.com/apache/flink/pull/14678#issuecomment-772707208 @rmetzger As I think it is a common issue of using a different classloader in runtime. Log4j issue can be an example of using the config

[GitHub] [flink] HuangZhenQiu commented on pull request #14678: [FLINK-20833][runtime] Add pluggable failure listener in job manager

2021-01-30 Thread GitBox
HuangZhenQiu commented on pull request #14678: URL: https://github.com/apache/flink/pull/14678#issuecomment-770324596 @rmetzger Thanks for these suggestions. Updated accordingly. Please review it again at your most convenient time.

[GitHub] [flink] HuangZhenQiu commented on pull request #14678: [FLINK-20833][runtime] Add pluggable failure listener in job manager

2021-01-21 Thread GitBox
HuangZhenQiu commented on pull request #14678: URL: https://github.com/apache/flink/pull/14678#issuecomment-764968449 @rmetzger @zentol Thanks for these comments. Please review it again after the build is green. This is

[GitHub] [flink] HuangZhenQiu commented on pull request #14678: [FLINK-20833][runtime] Add pluggable failure listener in job manager

2021-01-21 Thread GitBox
HuangZhenQiu commented on pull request #14678: URL: https://github.com/apache/flink/pull/14678#issuecomment-764968449 @rmetzger @zentol Thanks for these comments. Please review it again after the build is green. This is