[GitHub] [flink] KarmaGYZ commented on pull request #18360: [FLINK-25329][runtime] Support memory execution graph store in session cluster

2022-01-25 Thread GitBox
KarmaGYZ commented on pull request #18360: URL: https://github.com/apache/flink/pull/18360#issuecomment-1020946947 @zjureel I think we need also ignore the `maximumCacheSizeBytes` in this case. However, there might be a lot of "if...else" in `FileExecutionGraphInfoStore`. Maybe we should

[GitHub] [flink] KarmaGYZ commented on pull request #18360: [FLINK-25329][runtime] Support memory execution graph store in session cluster

2022-01-25 Thread GitBox
KarmaGYZ commented on pull request #18360: URL: https://github.com/apache/flink/pull/18360#issuecomment-1020946947 @zjureel I think we need also ignore the `maximumCacheSizeBytes` in this case. However, there might be a lot of "if...else" in `FileExecutionGraphInfoStore`. Maybe we should

[GitHub] [flink] KarmaGYZ commented on pull request #18360: [FLINK-25329][runtime] Support memory execution graph store in session cluster

2022-01-18 Thread GitBox
KarmaGYZ commented on pull request #18360: URL: https://github.com/apache/flink/pull/18360#issuecomment-1016116941 Thanks for the PR, @zjureel . I think it is a valid improvement. Regarding the implementation, I think we can simply introduce a config option "jobstore.flush-to-disk" to