[GitHub] [flink] Kwafoor commented on pull request #18498: [FLINK-25801][ metrics]add cpu processor metric of taskmanager

2022-03-10 Thread GitBox
Kwafoor commented on pull request #18498: URL: https://github.com/apache/flink/pull/18498#issuecomment-1064683134 > I don't see what that gives you though. if the existing load metric is close to 1 you already know that an increase of the number of CPU cores could make sense. Multiplying

[GitHub] [flink] Kwafoor commented on pull request #18498: [FLINK-25801][ metrics]add cpu processor metric of taskmanager

2022-03-09 Thread GitBox
Kwafoor commented on pull request #18498: URL: https://github.com/apache/flink/pull/18498#issuecomment-1063763070 > This to me sounds more like something that should be logged; we generally avoid exposing inherently constant values as metrics. Not inherently constant values.This

[GitHub] [flink] Kwafoor commented on pull request #18498: [FLINK-25801][ metrics]add cpu processor metric of taskmanager

2022-03-08 Thread GitBox
Kwafoor commented on pull request #18498: URL: https://github.com/apache/flink/pull/18498#issuecomment-1062527594 > This change to display flink application cpu resources used so the user can know and adjust flink resources. This feature is particularly useful if multiple applications

[GitHub] [flink] Kwafoor commented on pull request #18498: [FLINK-25801][ metrics]add cpu processor metric of taskmanager

2022-03-08 Thread GitBox
Kwafoor commented on pull request #18498: URL: https://github.com/apache/flink/pull/18498#issuecomment-1062523063 This change to display flink application cpu resources used so the user can know and adjust flink resources. This feature is particularly useful if multiple applications share