[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive

2023-01-10 Thread GitBox
MartijnVisser commented on PR #21542: URL: https://github.com/apache/flink/pull/21542#issuecomment-1377887404 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive

2023-01-06 Thread GitBox
MartijnVisser commented on PR #21542: URL: https://github.com/apache/flink/pull/21542#issuecomment-1373827479 > @MartijnVisser I hope its fine that I asked @gunnarmorling to take a look at this change :) > +1 to wait until we know that Hive still works. @rmetzger If you can have

[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive

2022-12-27 Thread GitBox
MartijnVisser commented on PR #21542: URL: https://github.com/apache/flink/pull/21542#issuecomment-1365743830 > I'm back. I have verified with Hive 2.3.9 & Hive 3.1.3, it still works after we exclude pentaho dependency. Thanks for checking! > `mvn dependency:tree` tells that

[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive

2022-12-22 Thread GitBox
MartijnVisser commented on PR #21542: URL: https://github.com/apache/flink/pull/21542#issuecomment-1362682534 > Theses change looks good to me. I perfer to find some times to verify it will still work in my hive test env. Let's leave it open until you have been able to verify it --

[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive

2022-12-22 Thread GitBox
MartijnVisser commented on PR #21542: URL: https://github.com/apache/flink/pull/21542#issuecomment-1362681986 > Hey @MartijnVisser, thanks for opening this PR. Stumbled upon this very same issue [just recently](https://www.morling.dev/blog/maven-what-are-you-waiting-for/). I can confirm

[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive

2022-12-22 Thread GitBox
MartijnVisser commented on PR #21542: URL: https://github.com/apache/flink/pull/21542#issuecomment-1362556563 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive

2022-12-21 Thread GitBox
MartijnVisser commented on PR #21542: URL: https://github.com/apache/flink/pull/21542#issuecomment-1361129709 @luoyuxia Let me know what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to