[GitHub] [flink] Myasuka commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

Myasuka commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1191127181 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java: ## @@ -394,18 +394,14 @@ public void confirm(SequenceNumber from,

[GitHub] [flink] Myasuka commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

Myasuka commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1180408546 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java: ## @@ -394,18 +394,14 @@ public void confirm(SequenceNumber from,

[GitHub] [flink] Myasuka commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

Myasuka commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1170930069 ## flink-dstl/flink-dstl-dfs/src/test/java/org/apache/flink/changelog/fs/FsStateChangelogWriterTest.java: ## @@ -246,15 +248,233 @@ void testFileAvailableAfterClose()

[GitHub] [flink] Myasuka commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

Myasuka commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1170863630 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/DuplicatingStateChangeFsUploader.java: ## @@ -51,14 +52,15 @@ * Store the meta of

[GitHub] [flink] Myasuka commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

Myasuka commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1170861351 ## flink-dstl/flink-dstl-dfs/src/test/java/org/apache/flink/changelog/fs/FsStateChangelogWriterTest.java: ## @@ -246,15 +248,233 @@ void testFileAvailableAfterClose()

[GitHub] [flink] Myasuka commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

Myasuka commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1170299609 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/DuplicatingStateChangeFsUploader.java: ## @@ -51,14 +52,15 @@ * Store the meta of

[GitHub] [flink] Myasuka commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

Myasuka commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1168984233 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/DuplicatingStateChangeFsUploader.java: ## @@ -51,14 +52,15 @@ * Store the meta of