[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-15 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-966782262 @twalthr @sjwiesman @Airblader @AHeise @tisonkun @fsk119 Excuse me, Could you help me to check it if you have free time ? Thanks a lot. -- This is an automated

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-15 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-966782262 @twalthr @sjwiesman @Airblader @AHeise @tisonkun @gaoyunhaii Excuse me, Could you help me to check it if you have free time ? Thanks a lot. -- This is an automated

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-15 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-966782262 @twalthr @Airblader @AHeise @tisonkun @gaoyunhaii Excuse me, Could you help me to check it if you have free time ? Thanks a lot. -- This is an automated message

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-15 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-966782262 @twalthr @Airblader @tillrohrmann @StephanEwen @tisonkun @gaoyunhaii Excuse me, Could you help me to check it if you have free time ? Thanks a lot. -- This is an

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-14 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-966782262 @Airblader @tillrohrmann @StephanEwen @tisonkun @gaoyunhaii Excuse me, Could you help me to check it if you have free time ? Thanks a lot. -- This is an automated

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-14 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-966782262 @AHeise @sjwiesman @Airblader @wuchong Excuse me, Could you help me to check it if you have free time ? Thanks a lot. -- This is an automated message from the

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-12 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-966782262 @AHeise @rkhachatryan @Airblader @wuchong Excuse me, Could you help me to check it if you have free time ? Thanks a lot. -- This is an automated message from the

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-12 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-966782262 @MartijnVisser @rkhachatryan @Airblader @wuchong Excuse me, Could you help me to check it if you have free time ? Thanks a lot. -- This is an automated message

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-11 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-966782262 @MartijnVisser @Airblader @wuchong Excuse me, Could you help me to check it if you have free time ? Thanks a lot. -- This is an automated message from the Apache

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-08 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-962281767 @Airblader @twalthr @wuchong Thank you so much for the review. I made some change. Could you help me to check it again? -- This is an automated message from the

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-10-25 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-943132915 Thanks @Airblader @twalthr @wuchong @xccui for the review. I updated it based on your comments. PTAL. Thx. -- This is an automated message from the Apache Git

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-10-22 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-943132915 Thanks @Airblader @twalthr @wuchong @MartijnVisser for the review. I updated it based on your comments. PTAL. Thx. -- This is an automated message from the Apache

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-10-22 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-943132915 Thanks @Airblader @twalthr @MartijnVisser for the review. I updated it based on your comments. PTAL. Thx. -- This is an automated message from the Apache Git

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-10-09 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-932250048 Thanks @Airblader @MartijnVisser for the review. Hi, @wuchong , @xintongsong @twalthr @pnowojski @fsk119 . Could you help me to merge it if there are nothing

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-10-08 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-932250048 Thanks @Airblader @MartijnVisser for the review. Hi, @wuchong , @xintongsong @twalthr @pnowojski . Could you help me to merge it if there are nothing inappropriate

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-10-02 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-932250048 Thanks @Airblader @MartijnVisser for the review. Hi, @wuchong , @xintongsong @twalthr @tisonkun . Could you help me to merge it if there are nothing inappropriate

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-29 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-925446816 Hi, @MartijnVisser @Airblader @twalthr @zhuzhurk @JingsongLi , I made some changes based on your suggestions. Could you help me to review it ? Thank you so much

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-28 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-925446816 Hi, @MartijnVisser @Airblader @twalthr @zhuzhurk @JingsongLi , I made some changes based on your suggestions. Could you help me to review it ? Thank you so much

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-28 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-925446816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-27 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-925446816 Hi, @MartijnVisser @Airblader @twalthr @zhuzhurk , I made some changes based on your suggestions. Could you help me to review it ? Thank you so much for your

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-27 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-925446816 Hi, @MartijnVisser @Airblader @twalthr @alpinegizmo , I made some changes based on your suggestions. Could you help me to review it ? Thank you so much for your

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-27 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-925446816 Hi, @MartijnVisser @Airblader @wuchong @twalthr @dawidwys @alpinegizmo , I made some changes based on your suggestions. Could you help me to review it ? Thank you

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-27 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-927241423 @alpinegizmo @dawidwys Could you help me to review this PR ? Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-26 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-925446816 Hi, @MartijnVisser @Airblader @wuchong @twalthr @libenchao , I made some changes based on your suggestions. Could you help me to review it ? Thank you so much for

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-24 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-925446816 Hi, @MartijnVisser @Airblader @wuchong @twalthr , I made some changes based on your suggestions. Could you help me to review it ? Thank you so much for your

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-23 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-925446816 Hi, @MartijnVisser @Airblader @wuchong @twalthr , I made some changes based on your suggestions. Could you help me to review it ? Thank you so much for your

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-19 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-920520153 Hi, @wuchong @twalthr @zhuzhurk @leonardBang @alpinegizmo . I made some changes in the ITCase part of the PR. Could you help me to review this PR if you have free

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-16 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-920520153 Hi, @wuchong @twalthr @zhuzhurk @leonardBang . I made some changes in the ITCase part of the PR. Could you help me to review this PR if you have free time? Thank

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-16 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-920520153 Hi, @wuchong @twalthr . I made some changes in the ITCase part of the PR. Could you help me to review this PR if you have free time? Thank you. -- This is an

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-09 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-916194876 Hi, @wuchong @leonardBang . Could you help me to check it if you have time? Thank you very much. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-08 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-913970522 > @wuchong @twalthr Thank you for your suggestions. I'll simplify the related documentation in this PR. > Looking forward to the refactoring next. @wuchong

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-09-03 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-905449651 @wuchong @twalthr @bowenli86 @leonardBang Could you help me to review this PR ? Thank you very much. -- This is an automated message from the Apache Git Service.

[GitHub] [flink] RocMarshal edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-08-27 Thread GitBox
RocMarshal edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-905449651 @wuchong @bowenli86 @leonardBang Could you help me to review this PR ? Thank you very much. -- This is an automated message from the Apache Git Service. To respond