Samrat002 commented on PR #20937:
URL: https://github.com/apache/flink/pull/20937#issuecomment-1285449056
Yes @MartijnVisser . I will follow conventions properly now onwards .
Thank you @MartijnVisser @dannycranmer @luoyuxia for reviewing and helping
me on first PR in Flink
Samrat002 commented on PR #20937:
URL: https://github.com/apache/flink/pull/20937#issuecomment-1284874067
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Samrat002 commented on PR #20937:
URL: https://github.com/apache/flink/pull/20937#issuecomment-1281758305
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Samrat002 commented on PR #20937:
URL: https://github.com/apache/flink/pull/20937#issuecomment-1279234327
@dannycranmer
I removed `org.apache.hadoop:hadoop-mapreduce-client-core:3.1.0` from
`NOTICE`.
> Regarding "The bundled Apache Hive org.apache.hive:hive-exec dependency"
Samrat002 commented on PR #20937:
URL: https://github.com/apache/flink/pull/20937#issuecomment-1277381643
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Samrat002 commented on PR #20937:
URL: https://github.com/apache/flink/pull/20937#issuecomment-1275927926
I will add the change to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Samrat002 commented on PR #20937:
URL: https://github.com/apache/flink/pull/20937#issuecomment-1274984521
- made changes in commit message as per contributing guide
- squashed all commits to one commit
- removed boiler plate example in description of pr
- updated "Does this pull
Samrat002 commented on PR #20937:
URL: https://github.com/apache/flink/pull/20937#issuecomment-1274946338
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Samrat002 commented on PR #20937:
URL: https://github.com/apache/flink/pull/20937#issuecomment-1274571975
looking into the test failure ! i will try to debug and get it fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Samrat002 commented on PR #20937:
URL: https://github.com/apache/flink/pull/20937#issuecomment-1273134840
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Samrat002 commented on PR #20937:
URL: https://github.com/apache/flink/pull/20937#issuecomment-1273065348
> hiveCatalog =
HiveTestUtils.createHiveCatalog(CatalogTest.TEST_CATALOG_NAME, "3.1.2");
Thank you @luoyuxia for reviewing the changes !
i have made changes as per your
11 matches
Mail list logo
