Sxnan commented on a change in pull request #13073:
URL: https://github.com/apache/flink/pull/13073#discussion_r513334483
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -163,6 +164,7 @@ public void sendSourceEventToCoordinator(SourceEvent event)
{
@Override
public void close() throws Exception {
eventTimeLogic.stopPeriodicWatermarkEmits();
+ currentMainOutput.emitWatermark(Watermark.MAX_WATERMARK);
Review comment:
Thanks for pointing out the problem and the detailed explaination. I
have made the change at 406f376, please take a look.
I also think the the SourceoperatorStreamTask should override the
`advanceToEndOfEventTime`. If @aljoscha can confirm that, I'd love to made that
change in this pr as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
