[GitHub] [flink] Tartarus0zm commented on a diff in pull request #20252: [FLINK-28463][flink-sql-parser] Flink dialect supports CREATE TABLE AS SELECT(CTAS) syntax

2022-07-22 Thread GitBox
Tartarus0zm commented on code in PR #20252: URL: https://github.com/apache/flink/pull/20252#discussion_r927546446 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] Tartarus0zm commented on a diff in pull request #20252: [FLINK-28463][flink-sql-parser] Flink dialect supports CREATE TABLE AS SELECT(CTAS) syntax

2022-07-22 Thread GitBox
Tartarus0zm commented on code in PR #20252: URL: https://github.com/apache/flink/pull/20252#discussion_r927388393 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] Tartarus0zm commented on a diff in pull request #20252: [FLINK-28463][flink-sql-parser] Flink dialect supports CREATE TABLE AS SELECT(CTAS) syntax

2022-07-20 Thread GitBox
Tartarus0zm commented on code in PR #20252: URL: https://github.com/apache/flink/pull/20252#discussion_r926251262 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] Tartarus0zm commented on a diff in pull request #20252: [FLINK-28463][flink-sql-parser] Flink dialect supports CREATE TABLE AS SELECT(CTAS) syntax

2022-07-20 Thread GitBox
Tartarus0zm commented on code in PR #20252: URL: https://github.com/apache/flink/pull/20252#discussion_r925578347 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java: ## @@ -76,6 +76,8 @@ public class SqlCreateTable extends

[GitHub] [flink] Tartarus0zm commented on a diff in pull request #20252: [FLINK-28463][flink-sql-parser] Flink dialect supports CREATE TABLE AS SELECT(CTAS) syntax

2022-07-20 Thread GitBox
Tartarus0zm commented on code in PR #20252: URL: https://github.com/apache/flink/pull/20252#discussion_r925577545 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java: ## @@ -189,6 +198,15 @@ public void validate() throws