[GitHub] [flink] TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution

2019-08-27 Thread GitBox
TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution URL: https://github.com/apache/flink/pull/9497#issuecomment-525257917 @mxm done. This is an automated message from

[GitHub] [flink] TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution

2019-08-26 Thread GitBox
TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution URL: https://github.com/apache/flink/pull/9497#issuecomment-525097298 Thanks for your review @mxm! Could you help merge this pull request?

[GitHub] [flink] TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution

2019-08-26 Thread GitBox
TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution URL: https://github.com/apache/flink/pull/9497#issuecomment-524776013 @kl0u @aljoscha could you take a look of this?

[GitHub] [flink] TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution

2019-08-23 Thread GitBox
TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution URL: https://github.com/apache/flink/pull/9497#issuecomment-524369543 @mxm now we pass api compatibility test also other tests. I think this pull request has reached a mergeable

[GitHub] [flink] TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution

2019-08-23 Thread GitBox
TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution URL: https://github.com/apache/flink/pull/9497#issuecomment-524230279 @flinkbot run travis This is an automated

[GitHub] [flink] TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution

2019-08-22 Thread GitBox
TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution URL: https://github.com/apache/flink/pull/9497#issuecomment-524150322 @flinkbot run travis This is an automated

[GitHub] [flink] TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution

2019-08-22 Thread GitBox
TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution URL: https://github.com/apache/flink/pull/9497#issuecomment-523812528 Thanks for your review @mxm ! In fact the only "break change" is in `ExecutionConfig`. I just added a

[GitHub] [flink] TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution

2019-08-21 Thread GitBox
TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution URL: https://github.com/apache/flink/pull/9497#issuecomment-523369386 I would assume there is few or none user make use of these method but the compatibility is promised by

[GitHub] [flink] TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution

2019-08-21 Thread GitBox
TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution URL: https://github.com/apache/flink/pull/9497#issuecomment-523368843 Travis failed at >08:54:01.376 [ERROR] Failed to execute goal

[GitHub] [flink] TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution

2019-08-21 Thread GitBox
TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution URL: https://github.com/apache/flink/pull/9497#issuecomment-523360925 Travis should fail on japicmp. I don't add `exclude` to verify the expected failure.