[GitHub] [flink] XComp commented on a diff in pull request #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

2022-06-07 Thread GitBox
XComp commented on code in PR #19807: URL: https://github.com/apache/flink/pull/19807#discussion_r891193045 ## flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/JdbcRowOutputFormatTest.java: ## @@ -76,27 +75,23 @@ public void

[GitHub] [flink] XComp commented on a diff in pull request #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

2022-06-07 Thread GitBox
XComp commented on code in PR #19807: URL: https://github.com/apache/flink/pull/19807#discussion_r891179677 ## flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/JdbcRowOutputFormatTest.java: ## @@ -76,27 +75,23 @@ public void

[GitHub] [flink] XComp commented on a diff in pull request #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

2022-06-07 Thread GitBox
XComp commented on code in PR #19807: URL: https://github.com/apache/flink/pull/19807#discussion_r891137397 ## flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/JdbcRowOutputFormatTest.java: ## @@ -76,27 +75,23 @@ public void

[GitHub] [flink] XComp commented on a diff in pull request #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

2022-06-03 Thread GitBox
XComp commented on code in PR #19807: URL: https://github.com/apache/flink/pull/19807#discussion_r889021351 ## flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunctionTest.java: ## @@ -107,7 +107,7 @@ public void