[GitHub] [flink] XComp commented on a diff in pull request #21137: [FLINK-29234][runtime] JobMasterServiceLeadershipRunner handle leader event in a separate executor to avoid dead lock

2022-11-03 Thread GitBox
XComp commented on code in PR #21137: URL: https://github.com/apache/flink/pull/21137#discussion_r1011489421 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunnerTest.java: ## @@ -46,45 +49,36 @@ import

[GitHub] [flink] XComp commented on a diff in pull request #21137: [FLINK-29234][runtime] JobMasterServiceLeadershipRunner handle leader event in a separate executor to avoid dead lock

2022-10-28 Thread GitBox
XComp commented on code in PR #21137: URL: https://github.com/apache/flink/pull/21137#discussion_r1008330056 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunnerTest.java: ## @@ -683,21 +665,66 @@ public void testJobAlreadyDone()

[GitHub] [flink] XComp commented on a diff in pull request #21137: [FLINK-29234][runtime] JobMasterServiceLeadershipRunner handle leader event in a separate executor to avoid dead lock

2022-10-27 Thread GitBox
XComp commented on code in PR #21137: URL: https://github.com/apache/flink/pull/21137#discussion_r1006684103 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunnerTest.java: ## @@ -683,21 +665,66 @@ public void testJobAlreadyDone()