[GitHub] [flink] XComp commented on a diff in pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

XComp commented on code in PR #21971: URL: https://github.com/apache/flink/pull/21971#discussion_r1191934305 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenTableSource.java: ## @@ -93,4 +93,9 @@ public ChangelogMode

[GitHub] [flink] XComp commented on a diff in pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

XComp commented on code in PR #21971: URL: https://github.com/apache/flink/pull/21971#discussion_r1190867729 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/SequenceGeneratorVisitor.java: ## @@ -82,25 +81,11 @@ public

[GitHub] [flink] XComp commented on a diff in pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

XComp commented on code in PR #21971: URL: https://github.com/apache/flink/pull/21971#discussion_r1190780451 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -49,10 +50,18 @@ /** * Creates a

[GitHub] [flink] XComp commented on a diff in pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

XComp commented on code in PR #21971: URL: https://github.com/apache/flink/pull/21971#discussion_r1118862415 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -264,7 +267,68 @@ void

[GitHub] [flink] XComp commented on a diff in pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

XComp commented on code in PR #21971: URL: https://github.com/apache/flink/pull/21971#discussion_r1118919072 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -83,9 +86,11 @@ public void open(

[GitHub] [flink] XComp commented on a diff in pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

XComp commented on code in PR #21971: URL: https://github.com/apache/flink/pull/21971#discussion_r1118867104 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -264,7 +267,68 @@ void

[GitHub] [flink] XComp commented on a diff in pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

XComp commented on code in PR #21971: URL: https://github.com/apache/flink/pull/21971#discussion_r1118856054 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -83,10 +85,22 @@ public void open(

[GitHub] [flink] XComp commented on a diff in pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

XComp commented on code in PR #21971: URL: https://github.com/apache/flink/pull/21971#discussion_r1112952301 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -83,10 +85,22 @@ public void open(

[GitHub] [flink] XComp commented on a diff in pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

XComp commented on code in PR #21971: URL: https://github.com/apache/flink/pull/21971#discussion_r1112201535 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -264,57 +267,63 @@ void