[GitHub] [flink] XComp commented on pull request #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

2022-06-08 Thread GitBox
XComp commented on PR #19807: URL: https://github.com/apache/flink/pull/19807#issuecomment-1149569411 The CI failure isn't related to the change but is caused by FLINK-27791. I'm going to go ahead and merge the PR. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] XComp commented on pull request #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

2022-06-03 Thread GitBox
XComp commented on PR #19807: URL: https://github.com/apache/flink/pull/19807#issuecomment-1145988076 I see, thanks for clarification. I guess, you're refering to [FLINK-25325](https://issues.apache.org/jira/browse/FLINK-25325). I'm just wondering why there's not `flink-connectors-jdbc`

[GitHub] [flink] XComp commented on pull request #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

2022-06-03 Thread GitBox
XComp commented on PR #19807: URL: https://github.com/apache/flink/pull/19807#issuecomment-1145971636 @alpreu Sorry for replying that late, but what about also migrating from junit4 to junit5 as part of that effort? Since we decided to go for assertj/junit5 in general? What's the