[GitHub] [flink] afedulov commented on a diff in pull request #19286: [FLINK-25931] Add projection pushdown support for CsvFormatFactory

2022-06-03 Thread GitBox
afedulov commented on code in PR #19286: URL: https://github.com/apache/flink/pull/19286#discussion_r889068627 ## flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvFormatFactoryTest.java: ## @@ -227,6 +228,24 @@ public void testInvalidIgnoreParseError() {

[GitHub] [flink] afedulov commented on a diff in pull request #19286: [FLINK-25931] Add projection pushdown support for CsvFormatFactory

2022-06-03 Thread GitBox
afedulov commented on code in PR #19286: URL: https://github.com/apache/flink/pull/19286#discussion_r889011653 ## flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataDeserializationSchema.java: ## @@ -206,6 +235,6 @@ public int hashCode() {

[GitHub] [flink] afedulov commented on a diff in pull request #19286: [FLINK-25931] Add projection pushdown support for CsvFormatFactory

2022-06-03 Thread GitBox
afedulov commented on code in PR #19286: URL: https://github.com/apache/flink/pull/19286#discussion_r889011653 ## flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataDeserializationSchema.java: ## @@ -206,6 +235,6 @@ public int hashCode() {

[GitHub] [flink] afedulov commented on a diff in pull request #19286: [FLINK-25931] Add projection pushdown support for CsvFormatFactory

2022-06-03 Thread GitBox
afedulov commented on code in PR #19286: URL: https://github.com/apache/flink/pull/19286#discussion_r889011653 ## flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataDeserializationSchema.java: ## @@ -206,6 +235,6 @@ public int hashCode() {

[GitHub] [flink] afedulov commented on a diff in pull request #19286: [FLINK-25931] Add projection pushdown support for CsvFormatFactory

2022-06-03 Thread GitBox
afedulov commented on code in PR #19286: URL: https://github.com/apache/flink/pull/19286#discussion_r889011653 ## flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataDeserializationSchema.java: ## @@ -206,6 +235,6 @@ public int hashCode() {

[GitHub] [flink] afedulov commented on a diff in pull request #19286: [FLINK-25931] Add projection pushdown support for CsvFormatFactory

2022-05-02 Thread GitBox
afedulov commented on code in PR #19286: URL: https://github.com/apache/flink/pull/19286#discussion_r862972424 ## flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataDeserializationSchema.java: ## @@ -65,13 +65,14 @@ public final class

[GitHub] [flink] afedulov commented on a diff in pull request #19286: [FLINK-25931] Add projection pushdown support for CsvFormatFactory

2022-04-27 Thread GitBox
afedulov commented on code in PR #19286: URL: https://github.com/apache/flink/pull/19286#discussion_r859663940 ## flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataDeserializationSchema.java: ## @@ -81,19 +82,34 @@ private