afedulov commented on PR #19286:
URL: https://github.com/apache/flink/pull/19286#issuecomment-1149671265
@godfreyhe the CI finally passed. I squashed the review commits, could you
please merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
afedulov commented on PR #19286:
URL: https://github.com/apache/flink/pull/19286#issuecomment-1149278416
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
afedulov commented on PR #19286:
URL: https://github.com/apache/flink/pull/19286#issuecomment-1149184639
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
afedulov commented on PR #19286:
URL: https://github.com/apache/flink/pull/19286#issuecomment-1148398154
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
afedulov commented on PR #19286:
URL: https://github.com/apache/flink/pull/19286#issuecomment-1145918386
@godfreyhe I reverted the optimization and propose to merge the pushdown
functionality as is.
--
This is an automated message from the Apache Git Service.
To respond to the message,
afedulov commented on PR #19286:
URL: https://github.com/apache/flink/pull/19286#issuecomment-1145107709
@godfreyhe thanks for the feedback.
> I find there is no any difference of the json node after deserialized
from the message between changing the csvSchema or not. See the debug info
afedulov commented on PR #19286:
URL: https://github.com/apache/flink/pull/19286#issuecomment-1143994493
@AHeise I am not sure that the proposed alternative approach makes things
much easier. I personally find the implementation of the projection
specification as an array of arrays
afedulov commented on PR #19286:
URL: https://github.com/apache/flink/pull/19286#issuecomment-1115147420
Thanks for your feedback @AHeise, I addressed your comments and added the
proposed optimization, please take a look.
--
This is an automated message from the Apache Git Service.
To
afedulov commented on PR #19286:
URL: https://github.com/apache/flink/pull/19286#issuecomment-426343
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
afedulov commented on PR #19286:
URL: https://github.com/apache/flink/pull/19286#issuecomment-1105830907
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
afedulov commented on pull request #19286:
URL: https://github.com/apache/flink/pull/19286#issuecomment-1084422541
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
11 matches
Mail list logo
