[GitHub] [flink] akalash commented on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client

2021-10-19 Thread GitBox
akalash commented on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-946787559 @dawidwys, thanks for the idea. I have checked it and it looks like it should work without any problem and this implementation looks more correct than current one. So let's

[GitHub] [flink] akalash commented on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client

2021-10-18 Thread GitBox
akalash commented on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-945739757 @dawidwys, I will try to implement it this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] akalash commented on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client

2021-10-14 Thread GitBox
akalash commented on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-943469088 I don't really sure about this proposal because we already create the client via clientBuilder, and then, by some reason, we need to wait on a future before the call of the one

[GitHub] [flink] akalash commented on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client

2021-10-11 Thread GitBox
akalash commented on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-940200558 > Do we really just stop debloating or do we trigger a failover? As I can see we just stopping debloating and no failover would be triggered > Shouldn't the