[GitHub] [flink] aljoscha commented on pull request #13808: [FLINK-19834] Make the TestSink reusable in all the sink related tests.

2020-10-28 Thread GitBox
aljoscha commented on pull request #13808: URL: https://github.com/apache/flink/pull/13808#issuecomment-717817391 I merged this, but I renamed all the builder methods to `setFoo()` instead of `addFoo()` because they are setting a thing and not adding to a list of things.

[GitHub] [flink] aljoscha commented on pull request #13808: [FLINK-19834] Make the TestSink reusable in all the sink related tests.

2020-10-27 Thread GitBox
aljoscha commented on pull request #13808: URL: https://github.com/apache/flink/pull/13808#issuecomment-717356452 I like the formatting in @guoweiM's code more than Klou's, I think Guowei uses the `EditorConfig` that I use... 😅 -