[GitHub] [flink] alpreu commented on pull request #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

2022-06-07 Thread GitBox
alpreu commented on PR #19807: URL: https://github.com/apache/flink/pull/19807#issuecomment-1148383867 > I see, thanks for clarification. I guess, you're refering to [FLINK-25325](https://issues.apache.org/jira/browse/FLINK-25325). I'm just wondering why there's not `flink-connectors-jdbc`

[GitHub] [flink] alpreu commented on pull request #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

2022-06-03 Thread GitBox
alpreu commented on PR #19807: URL: https://github.com/apache/flink/pull/19807#issuecomment-1145981118 > @alpreu Sorry for replying that late, but what about also migrating from junit4 to junit5 as part of that effort? Since we decided to go for assertj/junit5 in general? What's the

[GitHub] [flink] alpreu commented on pull request #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

2022-05-25 Thread GitBox
alpreu commented on PR #19807: URL: https://github.com/apache/flink/pull/19807#issuecomment-1136936452 Thanks for taking the time to review @snuyanzin, I just pushed again with the requested changes -- This is an automated message from the Apache Git Service. To respond to the message,