subject:"\[GitHub\] \[flink\] carp84 commented on pull request #12144\: \[FLINK\-17384\]\[flink\-dist\] support read hbase conf dir from flink.conf."

[GitHub] [flink] carp84 commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

2020-06-01 Thread GitBox

carp84 commented on pull request #12144: URL: https://github.com/apache/flink/pull/12144#issuecomment-637059489 @liuyongvs Thanks for updating the PR. Let me review first and see whether any change requested. This is an

[GitHub] [flink] carp84 commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

2020-05-28 Thread GitBox

carp84 commented on pull request #12144: URL: https://github.com/apache/flink/pull/12144#issuecomment-635496437 @liuyongvs I meant adding a test case for loading hbase conf (e.g. `HBaseConfigLoadingTest`) just like what we does now in `HadoopConfigLoadingTest#loadFromEnvVariables`.