[GitHub] [flink] carp84 commented on pull request #13393: [FLINK-19238] [RocksDB] Sanity check for arena block size

2020-10-20 Thread GitBox
carp84 commented on pull request #13393: URL: https://github.com/apache/flink/pull/13393#issuecomment-712655399 > > I (previously @juha-mynttinen-king) switched over to this account. I think we can keep this PR, if that's fine for you @carp84. > > Actually, it didn't work out. I

[GitHub] [flink] carp84 commented on pull request #13393: [FLINK-19238] [RocksDB] Sanity check for arena block size

2020-10-09 Thread GitBox
carp84 commented on pull request #13393: URL: https://github.com/apache/flink/pull/13393#issuecomment-706052335 Sidenote: Checking the latest RocksDB source codes ([write_buffer_manager.cc](https://github.com/facebook/rocksdb/blob/master/memtable/write_buffer_manager.cc#L54),

[GitHub] [flink] carp84 commented on pull request #13393: [FLINK-19238] [RocksDB] Sanity check for arena block size

2020-10-09 Thread GitBox
carp84 commented on pull request #13393: URL: https://github.com/apache/flink/pull/13393#issuecomment-706052335 Sidenote: Checking the latest RocksDB source codes ([write_buffer_manager.cc](https://github.com/facebook/rocksdb/blob/master/memtable/write_buffer_manager.cc#L54),

[GitHub] [flink] carp84 commented on pull request #13393: [FLINK-19238] [RocksDB] Sanity check for arena block size

2020-10-05 Thread GitBox
carp84 commented on pull request #13393: URL: https://github.com/apache/flink/pull/13393#issuecomment-704020362 > Hey. I'm going to lose access to the GitHub account soon, and not be able to modify the branch anymore. If changes are needed before merge, I guess I could create a new PR