[GitHub] [flink] curcur commented on pull request #12912: [FLINK-18595][network] Fix the deadlock issue by task thread and canceler thread in RemoteInputChannel

2020-07-21 Thread GitBox
curcur commented on pull request #12912: URL: https://github.com/apache/flink/pull/12912#issuecomment-661681066 Hey, @zhijiangW , I do not disagree with the solution for checking `isReleased`. For the second point, I mean if the cleanup of channels (sort by channel id for example)

[GitHub] [flink] curcur commented on pull request #12912: [FLINK-18595][network] Fix the deadlock issue by task thread and canceler thread in RemoteInputChannel

2020-07-19 Thread GitBox
curcur commented on pull request #12912: URL: https://github.com/apache/flink/pull/12912#issuecomment-660627891 1. Yes, I like Option 1. It looks very strange that two threads are trying to release the network resources at the same time. 2. Wondering whether releasing the input