[GitHub] [flink] dannycranmer commented on pull request #17583: [FLINK-24639][kinesis] Add UniformShardAssigner

2021-11-10 Thread GitBox
dannycranmer commented on pull request #17583: URL: https://github.com/apache/flink/pull/17583#issuecomment-965527617 Thanks @john-karp, LGTM, merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] dannycranmer commented on pull request #17583: [FLINK-24639][kinesis] Add UniformShardAssigner

2021-11-08 Thread GitBox
dannycranmer commented on pull request #17583: URL: https://github.com/apache/flink/pull/17583#issuecomment-963368030 Looks good to me, besides one comment about `cn` comments. Please rebase to resolve conflicts and I will merge one CI passes -- This is an automated message from the