dawidwys commented on issue #10674: [FLINK-15220][Connector/Kafka][Table] Add
startFromTimestamp in KafkaTableSource
URL: https://github.com/apache/flink/pull/10674#issuecomment-574046614
Thank you for the update @link3280 . Will merge it later today.
dawidwys commented on issue #10674: [FLINK-15220][Connector/Kafka][Table] Add
startFromTimestamp in KafkaTableSource
URL: https://github.com/apache/flink/pull/10674#issuecomment-573553180
@link3280 Generally looks really good. Could you just update the remaining
languages in the docs?
dawidwys commented on issue #10674: [FLINK-15220][Connector/Kafka][Table] Add
startFromTimestamp in KafkaTableSource
URL: https://github.com/apache/flink/pull/10674#issuecomment-573549541
@wuchong I am not sure if an additional `Z` is such a hassle for users. I
really think specifying
dawidwys commented on issue #10674: [FLINK-15220][Connector/Kafka][Table] Add
startFromTimestamp in KafkaTableSource
URL: https://github.com/apache/flink/pull/10674#issuecomment-573030241
The changes look mostly good. I have some concerns regarding using a
`LocalDateTime` as an `Instant`.