[GitHub] [flink] echauchot commented on pull request #19586: [FLINK-26824] [FLINK-27457] Upgrade Flink's supported Cassandra versions to match all Apache Cassandra supported versions and support flush

2022-05-09 Thread GitBox
echauchot commented on PR #19586: URL: https://github.com/apache/flink/pull/19586#issuecomment-1121051329 > > I could be in that case the uncovered race condition won't be fixed. So the output formats tests would fail on cassandra 4.0 between the two PR merges. I guess if we merge the two P

[GitHub] [flink] echauchot commented on pull request #19586: [FLINK-26824] [FLINK-27457] Upgrade Flink's supported Cassandra versions to match all Apache Cassandra supported versions and support flush

2022-05-09 Thread GitBox
echauchot commented on PR #19586: URL: https://github.com/apache/flink/pull/19586#issuecomment-1121050292 > Please note that the existing class `CassandraOutputFormatBase` that was previously used as a base class only for Tuple and Row outputFormats is now used as a base class for the 3 out

[GitHub] [flink] echauchot commented on pull request #19586: [FLINK-26824] [FLINK-27457] Upgrade Flink's supported Cassandra versions to match all Apache Cassandra supported versions and support flush

2022-05-06 Thread GitBox
echauchot commented on PR #19586: URL: https://github.com/apache/flink/pull/19586#issuecomment-1119594598 > Would you mind moving the flushing changes into another PR? I could be in that case the uncovered race condition won't be fixed. So the output formats tests would fail on cassan

[GitHub] [flink] echauchot commented on pull request #19586: [FLINK-26824] [FLINK-27457] Upgrade Flink's supported Cassandra versions to match all Apache Cassandra supported versions and support flush

2022-05-06 Thread GitBox
echauchot commented on PR #19586: URL: https://github.com/apache/flink/pull/19586#issuecomment-1119360748 @zentol I added the flush mechanism to all Cassandra output formats and the related tests (vastly inspired from `CassandraSinkBaseTest`) in the 3 last commits (different ticket). Please