[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-29 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r514195731 ## File path: flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.ts ## @@ -55,21 +59,38 @@ export class

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-28 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r513638113 ## File path: flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.ts ## @@ -55,21 +59,38 @@ export class

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-27 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r513184682 ## File path: flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.ts ## @@ -80,5 +97,9 @@ export class

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-27 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r513184231 ## File path: flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.ts ## @@ -57,9 +60,23 @@ export class

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-23 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r510773496 ## File path: flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.ts ## @@ -80,5 +83,25 @@ export class

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-23 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r510672189 ## File path: flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.html ## @@ -21,6 +21,8 @@ Path:

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-23 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r510672189 ## File path: flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.html ## @@ -21,6 +21,8 @@ Path:

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-21 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r509822287 ## File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-checkpoint.ts ## @@ -114,6 +115,8 @@ export interface CheckPointConfigInterface {

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-21 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r509822008 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java ## @@ -154,6 +161,7 @@ private

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-05 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r499961398 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java ## @@ -229,8 +242,8 @@ public

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-05 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r499718397 ## File path: flink-runtime-web/src/test/resources/rest_api_v1.snapshot ## @@ -557,7 +557,7 @@ }, "status" : {

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-01 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r498619466 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java ## @@ -229,8 +242,8 @@ public

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-01 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r498611476 ## File path: flink-runtime-web/src/test/resources/rest_api_v1.snapshot ## @@ -557,7 +557,7 @@ }, "status" : {

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-09-26 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r495432773 ## File path: flink-runtime-web/src/test/resources/rest_api_v1.snapshot ## @@ -3082,4 +3098,4 @@ } } } ] -} +} Review comment: done

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-09-26 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r495432833 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java ## @@ -113,23 +116,27 @@

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-09-25 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r494056973 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java ## @@ -113,6 +114,9 @@

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-09-24 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r494527680 ## File path: flink-runtime-web/src/test/resources/rest_api_v1.snapshot ## @@ -1254,6 +1263,9 @@ "num_acknowledged_subtasks" : { "type"

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-09-24 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r494529189 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointingStatisticsTest.java ## @@ -27,6 +28,8 @@ import

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-09-24 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r494527680 ## File path: flink-runtime-web/src/test/resources/rest_api_v1.snapshot ## @@ -1254,6 +1263,9 @@ "num_acknowledged_subtasks" : { "type"

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-09-24 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r494525996 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java ## @@ -18,32 +18,22 @@ package

[GitHub] [flink] gm7y8 commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-09-24 Thread GitBox
gm7y8 commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r494056973 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java ## @@ -113,6 +114,9 @@