[GitHub] [flink] godfreyhe commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed

2020-04-27 Thread GitBox
godfreyhe commented on a change in pull request #11397: URL: https://github.com/apache/flink/pull/11397#discussion_r415584774 ## File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientTest.java ## @@ -190,6 +176,47 @@ public void

[GitHub] [flink] godfreyhe commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed

2020-04-26 Thread GitBox
godfreyhe commented on a change in pull request #11397: URL: https://github.com/apache/flink/pull/11397#discussion_r415259812 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java ## @@ -196,8 +196,12 @@ public void open() {

[GitHub] [flink] godfreyhe commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed

2020-04-13 Thread GitBox
godfreyhe commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed URL: https://github.com/apache/flink/pull/11397#discussion_r407840751 ## File path:

[GitHub] [flink] godfreyhe commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed

2020-03-13 Thread GitBox
godfreyhe commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed URL: https://github.com/apache/flink/pull/11397#discussion_r392168376 ## File path:

[GitHub] [flink] godfreyhe commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed

2020-03-13 Thread GitBox
godfreyhe commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed URL: https://github.com/apache/flink/pull/11397#discussion_r392168376 ## File path:

[GitHub] [flink] godfreyhe commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed

2020-03-13 Thread GitBox
godfreyhe commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed URL: https://github.com/apache/flink/pull/11397#discussion_r392163257 ## File path: