godfreyhe commented on a change in pull request #15062:
URL: https://github.com/apache/flink/pull/15062#discussion_r586983114
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala
##########
@@ -108,18 +130,15 @@ object RexNodeExtractor extends Logging {
// converts the cnf condition to a list of AND conditions
val conjunctions = RelOptUtil.conjunctions(cnf)
- val convertedExpressions = new mutable.ArrayBuffer[Expression]
+ val convertibleRexNodes = new mutable.ArrayBuffer[RexNode]
val unconvertedRexNodes = new mutable.ArrayBuffer[RexNode]
- val inputNames = inputFieldNames.asScala.toArray
- val converter = new RexNodeToExpressionConverter(
- rexBuilder, inputNames, functionCatalog, catalogManager, timeZone)
conjunctions.asScala.foreach(rex => {
rex.accept(converter) match {
- case Some(expression) => convertedExpressions += expression
Review comment:
no, convertible nodes are that can be converted via
RexNodeToExpressionConverter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
