[GitHub] [flink] godfreyhe commented on a diff in pull request #20374: [FLINK-28709] Implement dynamic filtering operators

2022-08-06 Thread GitBox
godfreyhe commented on code in PR #20374: URL: https://github.com/apache/flink/pull/20374#discussion_r939508279 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/DynamicFilteringData.java: ## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache

[GitHub] [flink] godfreyhe commented on a diff in pull request #20374: [FLINK-28709] Implement dynamic filtering operators

2022-08-03 Thread GitBox
godfreyhe commented on code in PR #20374: URL: https://github.com/apache/flink/pull/20374#discussion_r937368986 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/DynamicFilteringData.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache

[GitHub] [flink] godfreyhe commented on a diff in pull request #20374: [FLINK-28709] Implement dynamic filtering operators

2022-08-03 Thread GitBox
godfreyhe commented on code in PR #20374: URL: https://github.com/apache/flink/pull/20374#discussion_r937365940 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/DynamicFilteringData.java: ## @@ -26,30 +26,49 @@ import

[GitHub] [flink] godfreyhe commented on a diff in pull request #20374: [FLINK-28709] Implement dynamic filtering operators

2022-08-03 Thread GitBox
godfreyhe commented on code in PR #20374: URL: https://github.com/apache/flink/pull/20374#discussion_r937312617 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/dynamicfiltering/DynamicFilteringDataCollectorOperator.java: ## @@ -0,0

[GitHub] [flink] godfreyhe commented on a diff in pull request #20374: [FLINK-28709] Implement dynamic filtering operators

2022-08-03 Thread GitBox
godfreyhe commented on code in PR #20374: URL: https://github.com/apache/flink/pull/20374#discussion_r937308705 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/dynamicfiltering/DynamicFilteringDataCollectorOperator.java: ## @@ -0,0