[GitHub] [flink] guoweiM commented on pull request #13808: [FLINK-19834] Make the TestSink reusable in all the sink related tests.

2020-10-28 Thread GitBox
guoweiM commented on pull request #13808: URL: https://github.com/apache/flink/pull/13808#issuecomment-717821255 > +1 for merging from me as soon as AZP given green, but I think @aljoscha 's comments are not in the branch. > I merged this, but I renamed all the builder

[GitHub] [flink] guoweiM commented on pull request #13808: [FLINK-19834] Make the TestSink reusable in all the sink related tests.

2020-10-27 Thread GitBox
guoweiM commented on pull request #13808: URL: https://github.com/apache/flink/pull/13808#issuecomment-717708815 > I have some comments that have mainly to do with unused methods and base classes that can be made concrete. I have pushed my changes here (to make sure that I do not break