kl0u opened a new pull request #9607: [FLINK-13946] Remove job session related code from ExecutionEnvironment URL: https://github.com/apache/flink/pull/9607 ## What is the purpose of the change This PR removes code related to JobSessions from the `ExecutionEnvironment` and the `PlanExecutor`s. This code was added in the context of [FLINK-2097](https://issues.apache.org/jira/browse/FLINK-2097) but it was never activated, as illustrated by the comment at [ExecutionEnvironment.java#L285 ](https://github.com/apache/flink/blob/master/flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java#L285). The work in this PR is part of the preparation for the upcoming re-design of the whole Client/Executor API. ## Brief change log The changes in the subclasses of the `ExecutionEnvironment` remove methods that were setting session-related parameters and reflect the simplification of the `PlanExecutor` _lifecycle_ explained below (for `Local` and `RemoteEnvironment`). The changes to the `PlanExecutors` have to do with the executor's lifecycle. Now the executor itself controls its lifecycle (`start()` and `stop()` are `private`) and we instantiate an executor for each call to `executePlan()`. This allows to get rid of the reapers from the `Local` and `RemoteEnvironments` and the `lock` that protected concurrent access to the executor's state. The lifecycle is more explicit now and aligned with the current use of the `ExecutionEnvironment`. If in the future we choose to change this and decide to re-use execution environments, then we can add this functionality back, potentially under a different design/architecture. ## Verifying this change This change is a code cleanup so it is covered by existing tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented) Please have a look at this one @aljoscha and @tillrohrmann.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services