[GitHub] [flink] lirui-apache commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog

2019-05-23 Thread GitBox
lirui-apache commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog URL: https://github.com/apache/flink/pull/8449#issuecomment-495451146 Made `ensureTableAndPartitionMatch` static. Several other methods can't be static, unless we pass the needed non-static

[GitHub] [flink] lirui-apache commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog

2019-05-23 Thread GitBox
lirui-apache commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog URL: https://github.com/apache/flink/pull/8449#issuecomment-495193379 Rebase and address comments. @bowenli86 @xuefuz let me know if I missed anything. Thanks.

[GitHub] [flink] lirui-apache commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog

2019-05-22 Thread GitBox
lirui-apache commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog URL: https://github.com/apache/flink/pull/8449#issuecomment-495051154 > @lirui-apache Thank you very much for the update! > > I just spotted that, currently how several APIs impl work

[GitHub] [flink] lirui-apache commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog

2019-05-22 Thread GitBox
lirui-apache commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog URL: https://github.com/apache/flink/pull/8449#issuecomment-494675094 Rebased and addressed comments. @bowenli86 @xuefuz please take another look. Thanks.