[GitHub] [flink] lirui-apache commented on issue #8987: [FLINK-13090][hive] Test Hive connector with hive runner

2019-07-09 Thread GitBox
lirui-apache commented on issue #8987: [FLINK-13090][hive] Test Hive connector with hive runner URL: https://github.com/apache/flink/pull/8987#issuecomment-509508883 Rebased and addressed comments. @bowenli86 please take another look, thanks.

[GitHub] [flink] lirui-apache commented on issue #8987: [FLINK-13090][hive] Test Hive connector with hive runner

2019-07-04 Thread GitBox
lirui-apache commented on issue #8987: [FLINK-13090][hive] Test Hive connector with hive runner URL: https://github.com/apache/flink/pull/8987#issuecomment-508609720 @xuefuz I don't think we need to worry about licenses because all the newly introduced deps are in test scope and only

[GitHub] [flink] lirui-apache commented on issue #8987: [FLINK-13090][hive] Test Hive connector with hive runner

2019-07-04 Thread GitBox
lirui-apache commented on issue #8987: [FLINK-13090][hive] Test Hive connector with hive runner URL: https://github.com/apache/flink/pull/8987#issuecomment-508474727 cc @xuefuz @bowenli86 @zjuwangg Please note although the PR comes with a shim for hive runner, I haven't verified it