liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-1008662267
@dmvk @AHeise Hi, as the issue
[https://issues.apache.org/jira/browse/FLINK-25224] and the pull request
[https://github.com/apache/flink/pull/18059] was sloved and merged,
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-990645530
> In general I agree with the sentiment of the patch. Few things that need
to be addressed:
>
> * As the whole hadoop ecosystem is slowly phasing out and lot of users
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-989471157
@dmvk Hi, sorry to bother, I think it's not useful to move the to flink-hadoop-fs from runtime. Cause when we load the
HadoopUtils, we will load the Hadoop class, then throw
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-989339562
@dmvk Hi, THX for your reply, I get your points. So there maybe these
changes that I should give:
- bump the hadoop version up to get rid of reflections : I will create a
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-96699
@AHeise Hi, I just rebased the latest commit of the master branch, then I
got a docs_404_check fail in the CI work. I did not get the useful log, what
should I do now, it
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-988856179
@flinkbot run azure re-run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-988674554
Resolv the conflict & squash all the commits into one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-988365115
@AHeise Hi, maybe there is a time difference of more than ten hours between
us. It is difficult to form continuous communication. When are you free? I can
wait for you to
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-987670013
@AHeise I did somethings for the hadoop classpath check and ci test. I think
it works. Now all the test were pass, and the ci work was success. Could you
review it again?
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-987524606
> Test failures show that your Hadoop configuraiton hack is not enough to
properly detect if Hadoop is on CP or not. @zentol do we better options?
@AHeise @zentol So
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-986590881
@AHeise I squashed all the commits into one, then changed the commit
message, please help to review it.
--
This is an automated message from the Apache Git Service.
To
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-985990753
@AHeise I add two more commits for the CI works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-985932863
>
@AHeise THX, I think I fix it, can you review it in the new commit?
Additionally, there are other commits that reply your change requests, could
you help to review
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-985233869
@AHeise THX for your reply, these were worthy advice for me. I will handle
it case by case. Give me some time.
--
This is an automated message from the Apache Git Service.
liufangqi commented on pull request #17958:
URL: https://github.com/apache/flink/pull/17958#issuecomment-985232979
>
@AHeise , Sorry to bother, it seems that i put this option into a wrong
file, can I ask for advice what file should I put into?
--
This is an automated message
15 matches
Mail list logo
