liuyongvs commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-1012689676
hi @tillrohrmann @Thesharing ,do you have time ,sorry to @ you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
liuyongvs commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-1011969412
hi @tillrohrmann @Thesharing ci passed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
liuyongvs commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-1011814363
> ```
> MINUTES(ChronoUnit.MINUTES, singular("min"), singular("m"),
plural("minute"))
> ```
yes, but if we change to MINUTES(ChronoUnit.MINUTES, singular("min"),
liuyongvs commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-1010567298
hi @Thesharing , orignial commits are 4, i just reset the first commit and
rebase code, then ci is running and you can see the log
--
This is an automated message from the
liuyongvs commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-1009893462
@Thesharing it will need modify lots of files. you can see my commits before
such as docs and XXplan.out, which will validate the plan contents
--
This is an automated
liuyongvs commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-1009743473
hi @Thesharing @tillrohrmann sorry for late response. if we do not want to
make changes such as docs and many file, we can change code from
MINUTES(ChronoUnit.MINUTES,
liuyongvs commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-980532189
> Why will it throw an exception @liuyongvs? I think this is a sign that we
shouldn't merge this change as is. Moreover, why does this PR changes so many
unrelated files? If
liuyongvs commented on pull request #1:
URL: https://github.com/apache/flink/pull/1#issuecomment-979708663
@Thesharing , but if not modified the existing configurations, it will
throw exception. and the "m" is also supports. so i think it is not problem,
what do you think
