[GitHub] [flink] matriv commented on a change in pull request #17759: [FLINK-24608][table-planner][table-runtime] Fix issue with missing timestamp

2021-11-18 Thread GitBox
matriv commented on a change in pull request #17759: URL: https://github.com/apache/flink/pull/17759#discussion_r752424061 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSinkITCase.java ## @@ -0,0 +1,

[GitHub] [flink] matriv commented on a change in pull request #17759: [FLINK-24608][table-planner][table-runtime] Fix issue with missing timestamp

2021-11-17 Thread GitBox
matriv commented on a change in pull request #17759: URL: https://github.com/apache/flink/pull/17759#discussion_r751610659 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSinkITCase.java ## @@ -0,0 +1,

[GitHub] [flink] matriv commented on a change in pull request #17759: [FLINK-24608][table-planner][table-runtime] Fix issue with missing timestamp

2021-11-17 Thread GitBox
matriv commented on a change in pull request #17759: URL: https://github.com/apache/flink/pull/17759#discussion_r751498019 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSinkITCase.java ## @@ -0,0 +1,

[GitHub] [flink] matriv commented on a change in pull request #17759: [FLINK-24608][table-planner][table-runtime] Fix issue with missing timestamp

2021-11-17 Thread GitBox
matriv commented on a change in pull request #17759: URL: https://github.com/apache/flink/pull/17759#discussion_r751487330 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sink/StreamRecordTimestampInserter.java ## @@ -0,0 +1

[GitHub] [flink] matriv commented on a change in pull request #17759: [FLINK-24608][table-planner][table-runtime] Fix issue with missing timestamp

2021-11-12 Thread GitBox
matriv commented on a change in pull request #17759: URL: https://github.com/apache/flink/pull/17759#discussion_r748380293 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java ## @@ -351,6 +356,16

[GitHub] [flink] matriv commented on a change in pull request #17759: [FLINK-24608][table-planner][table-runtime] Fix issue with missing timestamp

2021-11-12 Thread GitBox
matriv commented on a change in pull request #17759: URL: https://github.com/apache/flink/pull/17759#discussion_r748179531 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/DataStreamJavaITCase.java ## @@ -713,6 +732,

[GitHub] [flink] matriv commented on a change in pull request #17759: [FLINK-24608][table-planner][table-runtime] Fix issue with missing timestamp

2021-11-11 Thread GitBox
matriv commented on a change in pull request #17759: URL: https://github.com/apache/flink/pull/17759#discussion_r747485884 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java ## @@ -322,7 +323,8

[GitHub] [flink] matriv commented on a change in pull request #17759: [FLINK-24608][table-planner][table-runtime] Fix issue with missing timestamp

2021-11-11 Thread GitBox
matriv commented on a change in pull request #17759: URL: https://github.com/apache/flink/pull/17759#discussion_r747305885 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sink/TimestampOperator.java ## @@ -0,0 +1,50 @@ +/* +