[GitHub] [flink] onyourhead commented on pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties

2022-05-18 Thread GitBox
onyourhead commented on PR #19628: URL: https://github.com/apache/flink/pull/19628#issuecomment-1129662170 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] onyourhead commented on pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties

2022-05-18 Thread GitBox
onyourhead commented on PR #19628: URL: https://github.com/apache/flink/pull/19628#issuecomment-1129660837 > Please run `mvn spotless:apply` locally. Your current changes are not in line with our formatting guide lines. Sorry, I'm not familiar with the process of participating in

[GitHub] [flink] onyourhead commented on pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties

2022-05-17 Thread GitBox
onyourhead commented on PR #19628: URL: https://github.com/apache/flink/pull/19628#issuecomment-1128589572 @fapaul Can you help review the code above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] onyourhead commented on pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties

2022-05-06 Thread GitBox
onyourhead commented on PR #19628: URL: https://github.com/apache/flink/pull/19628#issuecomment-1119595202 Because there are some commits behind the master branch, the code of the backport is a little different. And `KafkaSinkBuilderTest` only exists in the master branch. -- This is an