oripwk opened a new pull request #17834:
URL: https://github.com/apache/flink/pull/17834


   ## What is the purpose of the change
   
   Supporting Boolean values for Datadog metrics reporter.
   
   
   ## Brief change log
   
     - `DGauge` is now parameterized in type `T` and will map boolean values to 
either `0` or `1` appropriately
   
   ## Verifying this change
   
   *(Please pick either of the following options)*
   
   This change added tests and can be verified as follows:
   
     - Add a test case for DGauges that checks both booleans, and Numbers
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (not applicable)
       Other reporters (such as Prometheus) know how to deal with Boolean 
values but their documentation does not mention it, so no reason to mention it 
in the Datadog reporter. Seems to be trivial.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to