piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support
for AzureFS
URL: https://github.com/apache/flink/pull/8117#issuecomment-495319623
@tillrohrmann - did you get a chance to take a stab at this?
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support
for AzureFS
URL: https://github.com/apache/flink/pull/8117#issuecomment-491016295
Thanks @tillrohrmann. I'm happy to put in a follow up on the shading stuff.
Can sit down with that next week and put in a fresh
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support
for AzureFS
URL: https://github.com/apache/flink/pull/8117#issuecomment-490264770
@tillrohrmann - I'm not really sure I understand why we need the
flink-hadoop-fs-shaded module. Is the whole point of that to
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support
for AzureFS
URL: https://github.com/apache/flink/pull/8117#issuecomment-489140860
Ok I think I didn't catch the issue as I was using mvn 3.5 and it seems that
the shade plugin behaves a bit differently on it.
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support
for AzureFS
URL: https://github.com/apache/flink/pull/8117#issuecomment-489094928
Yeah let me check. I kicked off a `mvn clean install -DskipTests` on my
machine before submitting and that seems to have gone
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support
for AzureFS
URL: https://github.com/apache/flink/pull/8117#issuecomment-488195295
Seems like the missing ingredient was this commit:
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support
for AzureFS
URL: https://github.com/apache/flink/pull/8117#issuecomment-488128359
P.S. @tillrohrmann / @shuai-xu - I was able to test this out on a hadoop
cluster. I had to copy the following jars to my lib
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support
for AzureFS
URL: https://github.com/apache/flink/pull/8117#issuecomment-488112927
@tillrohrmann do you know if there's any special setup required for the
flink e2e tests to run on developer machines? I'm
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support
for AzureFS
URL: https://github.com/apache/flink/pull/8117#issuecomment-487765637
Thanks for getting back and taking a look @tillrohrmann and @shuai-xu. To
answer some of your top level comments / questions:
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support
for AzureFS
URL: https://github.com/apache/flink/pull/8117#issuecomment-482722850
@Myasuka - did you get a chance to take a look at the rework? Anything else
to address or can we merge this?
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support
for AzureFS
URL: https://github.com/apache/flink/pull/8117#issuecomment-480938035
@Myasuka - thanks for taking a look. Updated to add this to opt.xml and some
docs as well. Let me know if you think I should
11 matches
Mail list logo
