[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-07-06 Thread GitBox
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-654058889 > Thanks for the contribution. Why default value is 1? Why not keep Int.Max? @JingsongLi Thanks for your reply , The details link

[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-07-06 Thread GitBox
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-654045783 @JingsongLi @wuchong Can you review this PR for me? thanks. This is an automated message from the Apache Git

[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-06-30 Thread GitBox
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-651727239 @becketqin The problems have been solved, and the current error seems to have nothing to do with our changes . Looking forward to your reply , thanks

[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-06-29 Thread GitBox
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-651554556 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-06-29 Thread GitBox
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-651156382 > @pyscala Thanks for the patch. LGTM. Can we add a unit test for this? thanks @becketqin for your reply ,i will add a unit test for this

[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-06-09 Thread GitBox
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-641707884 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-06-09 Thread GitBox
pyscala commented on pull request #12566: URL: https://github.com/apache/flink/pull/12566#issuecomment-641693599 Hi @becketqin ,appreciate for your time to review this PR,thanks This is an automated message from the Apache