[GitHub] [flink] pyscala commented on pull request #13276: [FLINK-18604][connectors/HBase] HBase ConnectorDescriptor can not work in Table API

2020-09-16 Thread GitBox
pyscala commented on pull request #13276: URL: https://github.com/apache/flink/pull/13276#issuecomment-693195891 > @pyscala Can you create a PR for release-1.11? @JingsongLi , sure, i will do it later This is an

[GitHub] [flink] pyscala commented on pull request #13276: [FLINK-18604][connectors/HBase] HBase ConnectorDescriptor can not work in Table API

2020-09-14 Thread GitBox
pyscala commented on pull request #13276: URL: https://github.com/apache/flink/pull/13276#issuecomment-692424268 @JingsongLi I finished and hope you take a look, thanks. This is an automated message from the Apache Git

[GitHub] [flink] pyscala commented on pull request #13276: [FLINK-18604][connectors/HBase] HBase ConnectorDescriptor can not work in Table API

2020-09-10 Thread GitBox
pyscala commented on pull request #13276: URL: https://github.com/apache/flink/pull/13276#issuecomment-690080794 > Hi @pyscala , I meant we should add a ITCase for this, I think this bug is caused by the absence of ITCase in previous PR. > (Maybe add a case in `HBaseConnectorITCase`)

[GitHub] [flink] pyscala commented on pull request #13276: [FLINK-18604][connectors/HBase] HBase ConnectorDescriptor can not work in Table API

2020-09-09 Thread GitBox
pyscala commented on pull request #13276: URL: https://github.com/apache/flink/pull/13276#issuecomment-689417861 > Hi @pyscala , thanks for contribution, can you add test for this? @JingsongLi , Thanks for your reply. I will add the test later.

[GitHub] [flink] pyscala commented on pull request #13276: [FLINK-18604][connectors/HBase] HBase ConnectorDescriptor can not work in Table API

2020-08-29 Thread GitBox
pyscala commented on pull request #13276: URL: https://github.com/apache/flink/pull/13276#issuecomment-683257195 Hi @JingsongLi , appreciate for your time to review this PR,thanks This is an automated message from the