reswqa commented on PR #22084:
URL: https://github.com/apache/flink/pull/22084#issuecomment-1494201748
Squash the two last commits. Merged % CI green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
reswqa commented on PR #22084:
URL: https://github.com/apache/flink/pull/22084#issuecomment-1493721859
FYI：If there are no other concerns, I will merge this PR tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
reswqa commented on PR #22084:
URL: https://github.com/apache/flink/pull/22084#issuecomment-1482982621
Thanks @akalash and @1996fanrui for the review.
> Is there an easy way to check that we allocate an overdraft buffer only
when isRequestedSizeReached? I mean we can create test
reswqa commented on PR #22084:
URL: https://github.com/apache/flink/pull/22084#issuecomment-1457725482
Thanks @1996fanrui for the review and catch the bug, I have updated this
according to your comments, please take a look again.
--
This is an automated message from the Apache Git
reswqa commented on PR #22084:
URL: https://github.com/apache/flink/pull/22084#issuecomment-1452263845
@1996fanrui and @wsry, would you mind taking a look at this? This pr
currently can be reviewed, but not the final status. Because there may be some
tests to be added and migrated to
