[GitHub] [flink] rkhachatryan commented on pull request #15173: [FLINK-21367][Connectors / JDBC] Support objectReuse in JDBC sink

2021-07-18 Thread GitBox
rkhachatryan commented on pull request #15173: URL: https://github.com/apache/flink/pull/15173#issuecomment-882080147 Hi @Bruschkov, I've implemented the test in #16528 and also added some refactorings (to the existing code). Please let me know if you have any concerns about these PRs.

[GitHub] [flink] rkhachatryan commented on pull request #15173: [FLINK-21367][Connectors / JDBC] Support objectReuse in JDBC sink

2021-07-06 Thread GitBox
rkhachatryan commented on pull request #15173: URL: https://github.com/apache/flink/pull/15173#issuecomment-874732615 Yes, production code changes LGTM, only some tests are missing. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] rkhachatryan commented on pull request #15173: [FLINK-21367][Connectors / JDBC] Support objectReuse in JDBC sink

2021-07-06 Thread GitBox
rkhachatryan commented on pull request #15173: URL: https://github.com/apache/flink/pull/15173#issuecomment-874528468 Hi @Bruschkov, are you still working on this PR? (it would be nice to have it in 1.14) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] rkhachatryan commented on pull request #15173: [FLINK-21367][Connectors / JDBC] Support objectReuse in JDBC sink

2021-07-06 Thread GitBox
rkhachatryan commented on pull request #15173: URL: https://github.com/apache/flink/pull/15173#issuecomment-874528468 Hi @Bruschkov, are you still working on this PR? (it would be nice to have it in 1.14) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] rkhachatryan commented on pull request #15173: [FLINK-21367][Connectors / JDBC] Support objectReuse in JDBC sink

2021-03-23 Thread GitBox
rkhachatryan commented on pull request #15173: URL: https://github.com/apache/flink/pull/15173#issuecomment-805505956 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the