rmetzger commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-721758994
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rmetzger commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-721756082
I see. Thanks a lot for your patience and the explanations.
This is an automated message from the Apache Git
rmetzger commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-721712709
I rebased the change to master, locally the license check has passed.
Once you give approval, I'll clean up the history, rebase & run it on CI one
more time and then
rmetzger commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-721710429
Ah, sorry. My comments have been confusing. I've initially had a scope
there, then removed it (probably even before opening the PR, that's why I
assumed you are referring to
rmetzger commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-721684343
I've addressed this comment a while ago. Maybe you are looking at old
commits?
This is an automated message
rmetzger commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-721611660
Thanks a lot for your review. I addressed all outstanding comments.
Once you declare the changes so far to be good to be merged, I'll rebase to
master. We might have
rmetzger commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-720939621
Thanks a lot for your feedback. I pushed a commit addressing your comments.
This is an automated message from
rmetzger commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-718145230
> There is no benefit in having the generated files in git, it could just be
step of the release process
One benefit would be, that our release process is less
rmetzger commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-717967845
How would you integrate such a notice file generating build step into the CI
pipeline?
- I've quickly looked at building our own shade resource transformer, but
it
rmetzger commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-717859165
Once I'm done with the license check for this release, I can make an
assessment of how well the tool works.
If I'm confident that it can also handle edge-cases, I could look
rmetzger commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-717761562
Thanks a lot for taking a look. I believe the statement by the tool is
correct: The notice file contains the following dependency:
`com.apache.commons:commons-compress:1.20`,
11 matches
Mail list logo
