[GitHub] [flink] rmetzger commented on pull request #14909: [FLINK-21258] Add Canceling state for DeclarativeScheduler

2021-02-11 Thread GitBox
rmetzger commented on pull request #14909: URL: https://github.com/apache/flink/pull/14909#issuecomment-777433387 Thanks for your review! I'll remove the `TestInternalFailuresListener` and mock the ExecutionGraph to intercept the `failGlobal()` method, then merge the change.

[GitHub] [flink] rmetzger commented on pull request #14909: [FLINK-21258] Add Canceling state for DeclarativeScheduler

2021-02-10 Thread GitBox
rmetzger commented on pull request #14909: URL: https://github.com/apache/flink/pull/14909#issuecomment-776925910 I rebased this change to the latest master (thus fewer commits are included), and addressed all comments Once you confirm that the `testTaskFailuresAreIgnored()` doesn't