rovboyko commented on PR #19648:
URL: https://github.com/apache/flink/pull/19648#issuecomment-1140982244
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rovboyko commented on PR #19648:
URL: https://github.com/apache/flink/pull/19648#issuecomment-1138154479
Hi Timo @twalthr !
I've rewritten the solution according to your idea to use the `generateCast`
method.
I had to change the `CodeGeneratorCastRule` to it be able to declare not
rovboyko commented on PR #19648:
URL: https://github.com/apache/flink/pull/19648#issuecomment-1127778962
ping @twalthr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rovboyko commented on PR #19648:
URL: https://github.com/apache/flink/pull/19648#issuecomment-1123870692
> I left a comment. TBH I'm not sure if
[FLINK-19796](https://issues.apache.org/jira/browse/FLINK-19796) was actually
the right approach to fix the issue. We could have simply adapted
rovboyko commented on PR #19648:
URL: https://github.com/apache/flink/pull/19648#issuecomment-1119639236
> @MartijnVisser Would be great to backport it to 1.15 and I guess 1.14 as
well.
Yes, we discussed it, I'll do it.
--
This is an automated message from the Apache Git Service.
rovboyko commented on PR #19648:
URL: https://github.com/apache/flink/pull/19648#issuecomment-1119581469
@matriv Thank you for such thorough review!
I've fixed all and resolved all discussions.
Could you please take a look once again?
--
This is an automated message from the Apache
rovboyko commented on PR #19648:
URL: https://github.com/apache/flink/pull/19648#issuecomment-1119210213
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
