[GitHub] [flink] sap1ens commented on a diff in pull request #20475: [FLINK-28842][Connector/Kafka] Add client.id.prefix for the KafkaSink

2022-10-27 Thread GitBox
sap1ens commented on code in PR #20475: URL: https://github.com/apache/flink/pull/20475#discussion_r1007187247 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -398,6 +407,11 @@ private void

[GitHub] [flink] sap1ens commented on a diff in pull request #20475: [FLINK-28842][Connector/Kafka] Add client.id.prefix for the KafkaSink

2022-10-16 Thread GitBox
sap1ens commented on code in PR #20475: URL: https://github.com/apache/flink/pull/20475#discussion_r996570322 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaSinkOptions.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache

[GitHub] [flink] sap1ens commented on a diff in pull request #20475: [FLINK-28842][Connector/Kafka] Add client.id.prefix for the KafkaSink

2022-10-16 Thread GitBox
sap1ens commented on code in PR #20475: URL: https://github.com/apache/flink/pull/20475#discussion_r996570099 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -398,6 +407,11 @@ private void