[GitHub] [flink] shaoxuan-wang commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-24 Thread GitBox
shaoxuan-wang commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#issuecomment-495542544 @flinkbot approve all This is an automated message

[GitHub] [flink] shaoxuan-wang commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-24 Thread GitBox
shaoxuan-wang commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#issuecomment-495541432 @sunjincheng121 @c4e , I think it is OK to use parent as suffix. We already have `flink-test-utils-parent`

[GitHub] [flink] shaoxuan-wang commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-22 Thread GitBox
shaoxuan-wang commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#issuecomment-494873716 Thanks for the contribution, @c4e. The entire design looks good to me. I have gone over all the comments. It