sjwiesman commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-776248944
I've rebased and squashed my fixup commits. I will keep monitoring CI to
ensure everything passes but if there are not any other issues people view as
absolute blockers I
sjwiesman commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-776111829
@rmetzger thanks for the review. I've fixed the anchor tags for the
configuration and the tables. I'm finishing up the licensing right now and will
then rebase and squash my
sjwiesman commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-77697
Hugo checks for links, I need to update the docs test to just run the hugo
build command.
This is an
sjwiesman commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775546460
I've fixed the whitespace and added an arrow to the rest API docs. I'm still
struggling with the side bar, I'll keep working on it tomorrow.
sjwiesman commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775465028
@zentol I've updated the styling for the rest API and configurations.
Additonally, I've externalized the css to ` so if we want to continue to tweak
it that's where you
sjwiesman commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775405887
> In the old sidebar, when you open/close a section, it smoothly animates
the opening/closing. The new sidebar simply pops open/closed, which is
unfortunate (I find it hard
sjwiesman commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775388616
@zentol It's just during the build because of the sub-module. We don't
actually use these libraries.
@alpinegizmo I've fixed the spacing, font size, and search bar.
sjwiesman commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775382844
@alpinegizmo what browser are you using? The search box does not look like
that for me.
This is an
sjwiesman commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775366039
@zentol
* Updated dependencies:
`LICENSE.book` is for the underlying hugo theme the Flink docs are based on.
`LICENSE.katex` and `LICENSE.mermaid` are
sjwiesman commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775331271
@zentol Could you please help review 16a718d
This is an automated message from the Apache Git Service.
To
sjwiesman commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775327307
cc @rmetzger
This is an automated message from the Apache Git Service.
To respond to the message, please log
11 matches
Mail list logo
