[GitHub] [flink] sv3ndk commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-04-28 Thread GitBox
sv3ndk commented on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-828208840 Ok, thanks for letting me know. Looking forward to protobuf support in Flink! -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [flink] sv3ndk commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-04-26 Thread GitBox
sv3ndk commented on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-826620751 Hi all, Can I please collect your feed-back on my proposal for updating the current PR? What i suggest is simply to remove the configuration flag `readDefaultValues

[GitHub] [flink] sv3ndk commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-04-06 Thread GitBox
sv3ndk commented on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-814650640 Thanks for the feed-back @maosuhan , Indeed, I see what you mean, I think you're correct and I'm missing one case. If I understand things correctly, the logic we want

[GitHub] [flink] sv3ndk commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-03-29 Thread GitBox
sv3ndk commented on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-809618142 Thanks a lot for working on a Protobuf format! We also use that serialization mechanism at my company and will need such format soon, this is very useful. I have a differ